Code Review

Code Review

Reviewing the Timeout That Was Longer Than the Caller's

The service waited ten seconds for its dependency while the caller gave up after five, so the work continued for an audience that had left, and the caller's…

Code Review

Reviewing the Module-Level Dict That Every Request Wrote To

The cache lived at import scope, so it survived across requests and across users, and one user's entry was served to another, and the leak stopped only when…

Code Review

The Boolean Parameter Nobody Could Read at the Call Site

The call passed true and the reader had no idea what true meant, so the behaviour was guessed, and the guess was wrong in the one branch that mattered, and…

Code Review

Reviewing the Async Call Nobody Could Cancel

The request had no timeout and no cancellation, so the abandoned navigation left the fetch running, and the response wrote to a component that no longer…

Code Review

Reviewing the Money Math That Used a Float

The total was computed in binary floating point, so the sum was a cent off on some carts, and the difference only appeared when the decimals did not fit the…

Code Review

Reviewing the Retry That Had No Idempotency Key

The client retried the failed payment request on a timeout, and the original had succeeded, so the retry charged the customer a second time for one order…

Code Review

Reviewing the N+1 Query Hidden Inside a Serializer

The list endpoint issued one query for the rows and one per row for the relation, and the extra queries were invisible in the view because the serializer…

Code Review

Reviewing the Cache Key That Forgot the Locale

The cached fragment was keyed on the path only, so the first visitor's language was served to every subsequent visitor, and the mismatch looked like a…

Code Review

Reviewing the Loop That Fired Ten Thousand Model Calls at Once

The batch loop awaited every item concurrently with no semaphore, so the first burst rate limited itself, and the retry storm that followed turned a…

Code Review

Reviewing the Off-by-One the Model Put in the Pagination Loop

The loop fetched every page except the last, and the omission was invisible because the page count was right and the total was right, and the only wrong…

Code Review

Reviewing a Terraform Diff for the Resource It Will Replace

A one character change to an immutable attribute shows as a tidy edit in the diff and executes as a destroy plus create, and the review that prices the edit…

Opinion

The Pull Request Description Is the Specification

The diff shows what changed and the tests show what was checked, but the description is the only place the intent lives.