Code Review

Code Review

Reviewing a Promise Chain for the Rejection It Swallows

A catch that returns a fallback converts a failure into a value, and the caller downstream treats the fallback as data.

Code Review

Reviewing a useEffect for the Cleanup It Forgot

The listener, the timer and the subscription all outlive the component that created them, and the leak is invisible on the first mount and obvious on the tenth.

Code Review

Reviewing Python for the Mutable Default Argument and Its Cousins

The shared list default is the famous one, and reviewers catch it on sight. The module level cache, the captured dict and the class attribute list are its…

Code Review

Reviewing the Silent Default That Hid the Missing Config

The loader fell back to a built-in value when the key was absent, so the service ran with the wrong setting for a week, and the startup log said the…

Code Review

When an Agent Reviews an Agent, the Praise Is Guaranteed

Two models from the same family reviewed each other's code and agreed it was fine, because they share the same priors about what plausible code looks like.

Code Review

Reviewing Code the Author Cannot Explain

The pull request author accepted the diff from a tool and could not narrate its failure modes, so the review had no one to interrogate.

Code Review

Validate at the Boundary and Nowhere Else

Three validators in three layers, and the internal job that bypasses all of them. Scattered validation misses the one entry point nobody covered, and the…

Code Review

Reviewing Pagination Before Someone Requests a Million Rows

Offset pagination that scans, an unbounded page size, and a cursor that drifts when rows insert. The pagination diff looks like plumbing and contains the…

Code Review

The Pull Request That Logged an Email Address at Debug Level

Debug logging the full request body is one flag flip from production, and the request body is where the email, the token and the card reference live.

Code Review

Reviewing a Cache Layer for the Four Ways It Will Hurt You

A cache is reviewed for correctness on the happy path and fails on the edges: the cold start, the hot key, the poison entry and the deploy.

Code Review

Every Timeout Should Be Shorter Than the One Above It

A request chain is a ladder of deadlines, and when a lower rung is longer than the one above, the upper layer pays for work nobody will ever read.

Code Review

Reviewing Shared State by Asking What Happens Under Contention

Locks and shared state look correct in the single threaded reading of a review and fail only under contention, which is exactly the condition review never…